UpDownBase: Fix event subscription mismatch #3844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where the NumericUpDown control was not properly updating the text in the TextBox when focus was lost after invalid input. Adds a LostFocus event handler to update the textbox value. Adds UI tests to verify that values are updated as expected.
Keboo
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3827
UPDATE
Ooh, a failing test! It seems there is a requirement to revert back to original value on
LostFocusif the entered value is invalid...Not entirely sure how to handle that use-case, while still supporting
UpdateSourceTrigger=PropertyChanged🤔The
UpDownBasewas only subscribing to theLostFocusevent, but the unsubscribing theTextChangedevent. This is a potential event-handler leak, but also the root cause of the reported issue.This PR ensures only the
TextChangedevent is subscribed/unsubscribed, and then let's the internal binding system handle when to notify a bound view model property. As long as we callSetCurrentValue()for the "most frequent update source trigger", the built-in system will handle the rest for us (I am quite sure of).